API for Dataset/Dataset Member Allocation by aditya-ranshinge · Pull Request #473 · zowe/zss

aditya-ranshinge · 2022-05-16T14:21:38Z

Proposed changes

API for Dataset/Dataset Member Allocation was implemented in #351 this PR , which was reviewed by Leonty.
This PR is continuation of above mentioned PR where Allocation Unit, Average Record Unit, Primary Space, Secondary Space, Directory Blocks, Dataset Name Type attributes added for dataset creation.

This pull request implements the following feature:

API which enables the allocation of datasets and dataset members.
Add 'PUT' method to /datasetContents, accepts JSON body to specify dataset parameters

This PR depends upon the following PRs:
zowe/zowe-common-c#292

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Change in a documentation
Refactor the code
Chore, repository cleanup, updates the dependencies.
Breaking change (fix or feature that would cause existing functionality to not work as expected)

PR Checklist

Please delete options that are not relevant.

If the changes in this PR are meant for the next release / mainline, this PR targets the "staging" branch.
My code follows the style guidelines of this project (see: Contributing guideline)
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
New and existing unit tests pass locally with my changes
video or image is included if visual changes are made
Relevant update to CHANGELOG.md
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works, or describe a test method below

Testing

Further comments

Signed-off-by: Aditya Ranshinge <aranshinge@rocketsoftware.com>

…Directory Blocks, Dataset Name Type attributes for dataset creation Signed-off-by: Aditya Ranshinge <aranshinge@rocketsoftware.com>

Signed-off-by: Aditya Ranshinge <aranshinge@rocketsoftware.com>

…issue Signed-off-by: Aditya Ranshinge <aranshinge@rocketsoftware.com>

ifakhrutdinov · 2022-05-23T15:47:29Z

I'll review this once the zowe-common-c PR has been figured out.

Signed-off-by: Aditya Ranshinge <aranshinge@rocketsoftware.com>

…emoved unwanted functions and macros Signed-off-by: Aditya Ranshinge <aranshinge@rocketsoftware.com>

Signed-off-by: Aditya Ranshinge <aranshinge@rocketsoftware.com>

1000TurquoisePogs · 2022-07-28T19:46:57Z

+            rc = setTextUnit(TEXT_UNIT_INT24, 0, NULL, toi, DALBLKLN, configsCount, inputTextUnit);
+          }
+        }
+      } else if(!strcmp(propString, "status")) {


this should be called disp, not status, because disp is the term that everyone knows.

1000TurquoisePogs · 2022-07-28T19:47:47Z

+      } else if (!strcmp(propString, "ndisp")) {
+        if (!strcmp(valueString, "UNCATLG")){
+          parmDefn = DISP_UNCATLG;
+        } else if (!strcmp(valueString, "DELETE")){


if delete deletes... this shouldnt be in the PUT api at all.

I will remove it from PUT api

1000TurquoisePogs · 2022-07-28T19:53:49Z

+        }
+        rc = setTextUnit(TEXT_UNIT_CHAR, 0, NULL, parmDefn, DALSTATS, configsCount, inputTextUnit);
+      } else if (!strcmp(propString, "ndisp")) {
+        if (!strcmp(valueString, "UNCATLG")){


i'd like to know more about uncatalog to know if this is something we should be allowing the users to do.

There is very limited IBM documentation about UNCATLG parameter.
Explanation of other parameters is present but links pointing to UNCATLG doesn't have contents like this link https://www.ibm.com/docs/en/zos/2.1.0?topic=parameter-uncataloging-data-set

But what I have got so far is "In UNCATLG case the data set exists but it deletes the catalog entry from the catalog file. "

1000TurquoisePogs · 2022-07-28T19:54:49Z

I didn't mark this PR as bad or good but rather just saw some things that made me thing we should ask a senior mainframe user to get opinions on whether we should restrict the API to avoid people accidentally doing things they will regret due to having options they dont understand.

1000TurquoisePogs · 2022-07-28T20:01:11Z

+        if (valueStrLen <= CLASS_WRITER_SIZE){
+          rc = setTextUnit(TEXT_UNIT_STRING, valueStrLen, &(valueString)[0], 0, DALSPGNM, configsCount, inputTextUnit);
+        }
+      } else if(!strcmp(propString, "close")) {


meaning "autounallocate"

we should have code comments linking over here because these are super confusing and we will forget what these mean.
https://www.ibm.com/docs/en/zos/2.1.0?topic=mvs-zos-programming-authorized-assembler-services-guide
https://www-40.ibm.com/servers/resourcelink/svc00100.nsf/pages/zOSV2R3sa231371/$file/ieaa800_v2r3.pdf

Do you want me to add "autounallocate" comment here?
I have referred these docs https://www.ibm.com/docs/en/zos/2.4.0?topic=units-unallocation-close-specification-key-001c

1000TurquoisePogs · 2022-07-29T15:15:11Z

+        if (valueStrLen <= DD_NAME_LEN){
+          rc = setTextUnit(TEXT_UNIT_STRING, DD_NAME_LEN, &(valueString)[0], 0, DALRTDDN, configsCount, inputTextUnit);
+        }
+      } else if(!strcmp(propString, "spin")) {


Signed-off-by: Aditya Ranshinge <aranshinge@rocketsoftware.com>

aditya-ranshinge added 3 commits May 12, 2022 13:01

API for Dataset/Dataset Member Allocation - Tim

01d4832

Signed-off-by: Aditya Ranshinge <aranshinge@rocketsoftware.com>

Added Allocation Unit, Average Record Unit, Primary Secondary Space, …

3022a32

…Directory Blocks, Dataset Name Type attributes for dataset creation Signed-off-by: Aditya Ranshinge <aranshinge@rocketsoftware.com>

Updated zowe-common-c pointer

52beba4

Signed-off-by: Aditya Ranshinge <aranshinge@rocketsoftware.com>

aditya-ranshinge requested review from JoeNemo and ifakhrutdinov May 16, 2022 16:35

aditya-ranshinge marked this pull request as ready for review May 17, 2022 11:36

updated zowe-common-c pointer - type casting to resolve 64 bit build …

f61637f

…issue Signed-off-by: Aditya Ranshinge <aranshinge@rocketsoftware.com>

aditya-ranshinge added 3 commits June 2, 2022 16:04

review comments fix

b434d7f

Signed-off-by: Aditya Ranshinge <aranshinge@rocketsoftware.com>

used TextUnit structure instead of DynallocNewInputParms structure, r…

5cf3383

…emoved unwanted functions and macros Signed-off-by: Aditya Ranshinge <aranshinge@rocketsoftware.com>

removed unwanted comments

ad7a392

Signed-off-by: Aditya Ranshinge <aranshinge@rocketsoftware.com>

1000TurquoisePogs reviewed Jul 28, 2022

View reviewed changes

1000TurquoisePogs reviewed Jul 29, 2022

View reviewed changes

Fixed review comments

0f5cbdb

Signed-off-by: Aditya Ranshinge <aranshinge@rocketsoftware.com>

This was referenced Sep 2, 2022

Add swagger for dataset create api zowe/zlux-server-framework#441

Merged

dataset creation rest api #505

Merged

Uh oh!

Conversation

aditya-ranshinge commented May 16, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Type of change

PR Checklist

Testing

Further comments

Uh oh!

ifakhrutdinov commented May 23, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aditya-ranshinge Aug 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

1000TurquoisePogs commented Jul 28, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

aditya-ranshinge commented May 16, 2022 •

edited

Loading

ifakhrutdinov commented May 23, 2022 •

edited

Loading

aditya-ranshinge Aug 3, 2022 •

edited

Loading