With 7.0.1 release - Basic connection does not work on untrusted z/OSMF server. - #609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Root Cause & What Changed
In previous versions (e.g. 7.0.0), Basic authentication unconditionally hardcoded Unirest.config().verifySsl(false) globally for all requests. This introduced security risks (ignoring certificates in production) and concurrency bugs in multithreaded apps.
When Unirest was refactored to use isolated per-connection instances (UnirestInstance), setupSsl(...) was accidentally configured to run only for AuthType.SSL.
As a result, when using AuthType.BASIC:
Setting -Dzowe.sdk.allow.insecure.connection=true or -Dzowe.sdk.truststore.path was ignored.
Java defaulted to standard JVM cacerts validation.
Connections to self-signed or internal CA mainframe servers failed with: javax.net.ssl.SSLHandshakeException: PKIX path building failed.
The Code Fix Applied
ZosmfRequest.java was updated so setupSsl(...) is called for all authentication types (BASIC, TOKEN, and SSL).
PR introduces supports for all three SSL modes for Basic/Token connections: