Replace kong.unirest JSONObject with Jackson in ZosmfStatus - #581
Merged
Conversation
Signed-off-by: Ashish Kumar Dash <ashishdash2410@gmail.com>
frankgiordano
self-requested a review
July 20, 2026 18:51
frankgiordano
approved these changes
Jul 20, 2026
Collaborator
|
Good catch. This makes the code more readable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZosmfStatuswas the last file insrc/mainstill parsing JSON withkong.unirest.core.json.JSONObject; every other class in the SDK goes throughJsonUtils(Jackson). This brings it in line and removes that last non-Jackson JSON code path.Changes
JSONObject/optJSONArrayplugins-array parsing withJsonUtils.parse+JsonUtils.getArrayByField, the same pattern used inWorkflowList.getWorkflowsCommon.IntStream.rangeindexing with a plain for-each loop over theArrayNode.pluginsfield, anullvalue, and an empty array all still resolve to a zero-lengthZosmfPlugin[](verified viaroot.path(...).isArray()guard, which isfalsefor bothMissingNodeandNullNode).