Feat/delete migrated datasets in dns update - #573
Merged
frankgiordano merged 3 commits intoJul 15, 2026
Merged
Conversation
Signed-off-by: Charishma1707 <charishmaalam8@gmail.com>
frankgiordano
approved these changes
Jul 15, 2026
Collaborator
|
@Charishma1707 can you submit new PR and change * @author Charishma1707 with your real name.. we all use real names for this field. otherwise remove alias. thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR refactors the migrated dataset deletion (
hdelete) functionality into the new centralizedDsnUpdateclass.Why We Chose This Method Overloading Strategy
In Java, we cannot define the following two signatures at the same time:
Because both methods resolve to the exact same parameter type signature (
String,boolean), Java compilation will throw a duplicate method definition error.To circumvent this while keeping the API simple:
deleteMigrated(final String dataSetName)was added for standard deletion (defaults optional parameters tonull, excluding them from the request payload).deleteMigrated(final String dataSetName, final boolean wait, final boolean purge)was added to allow callers to explicitly specify both flags.deleteMigratedCommon(...)helper to eliminate code duplication and centralize payload construction.Changes Made
DsnUpdate.javadeleteMigratedpublic APIs.deleteMigratedCommon(...)helper.README.mdDsnUpdate, including dataset rename anddeleteMigrated()usage.Tests
DsnUpdateTest.java.Verification
mvn clean testCloses
Closes #567