Refactor DsnRename into DsnUpdate and introduce immutable rename input - #572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor
DsnRenameintoDsnUpdateto establish a single entry point for dataset update operations and provide a foundation for supporting additional z/OSMF dataset update APIs in the future.As part of this refactor, the rename API has been redesigned to use an immutable input object instead of overloaded methods with positional parameters.
Changes
Renamed
DsnRenametoDsnUpdate.Introduced an immutable
RenameInputDataclass to encapsulate rename request parameters.Replaced the overloaded rename methods with a single:
Centralized input validation within
RenameInputData.Removed mutable request state from the implementation.
Replaced internal varargs helper methods with strongly typed input.
Updated unit tests, documentation, and examples to reflect the new API.
Benefits
Example
Before
After
This refactor does not change the underlying z/OSMF rename functionality. It modernizes the API and establishes a consistent, extensible design for future dataset update operations.