Add option to use regular expressions in find popup#230
Open
max-nothacker wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a "Use regular expressions" toggle to the find popup, for PDF, EPUB, and snapshot views.
Requested on the forums: Feature Request: Support Content Search with Regex and another user request.
useRegexfind option alongside the existing case-sensitive/whole-words optionspdf-find-controller; EPUB/snapshot: in the DOM find worker.while composing a pattern): total-match cap set to 5000, snippet generation tokenizes a window around the match instead of the whole page, and single-letter patterns don't auto-search consistent with the pre-existing search behavior that already ignored single-letter patterns before this PR.Needed by: zotero/zotero#5993, which carries the localized string and 13 find tests (PDF, EPUB, snapshot).