Add support for link and visited link colors in themes#199
Open
tnajdek wants to merge 1 commit into
Open
Conversation
Member
|
This looks fine to me - @mrtcode? |
Member
|
Looks good overall, but this seems to regress Original theme + Reading Mode: links now render in the normal text color instead of staying visually distinguishable. 
|
tnajdek
force-pushed
the
custom-theme-colors-for-links
branch
from
0f326ab to
5c5eaa4
Compare
Member
Author
|
@mrtcode good catch, thanks! Fixed it and rebased. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend themes to provide link colors (active and visited). Custom themes can also provide values, current custom themes will fallback to text-color, which means users of custom themes should see no difference (but can tweak the themes to add new colors)
Requires two new .ftl strings in zotero/zotero.
This is a fix for problem reported here: https://forums.zotero.org/discussion/130492/bug-links-are-invisible-in-themes, using snapshot of the page from the example:
DARK
SEPIA
