chore(proxy): require kamal-proxy v1.0.0.1 (#93 workstream G) - #103
Merged
Conversation
## Summary The 3.0.0 release train's proxy side is publishing: v1.0.0.1 carries the certificate-system unification (kamal-proxy#84/#85 - no issuance for a name nobody asked for) and the disk-backed cache store (kamal-proxy#83). MINIMUM_VERSION moves to it; v1.0.0.0 must never be the minimum (unbounded SNI issuance hole). The flag manifest was regenerated from a binary built at the v1.0.0.1 tag (bin/sync-proxy-flags --binary): the only change is the version stamp - v1.0.0.1 adds no deploy or run flags, so the coverage canary had nothing new to decide. The integration seed (setup.sh) reads the constant dynamically and needs no edit. Full bin/test against the published ghcr image (the E4 handoff gate) runs before bin/release-dash 3.0.0, per the release ordering. ## Verification - [x] bundle exec rubocop --parallel passes - [x] unit suite passes (1311 runs) - flag canary green against the regenerated manifest Refs #93 (workstream G)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The gem side of workstream G:
MINIMUM_VERSIONmoves tov1.0.0.1(cert-system unification kamal-proxy#84/#85 + disk-backed cache store kamal-proxy#83).v1.0.0.0must never be the minimum — it carries the unbounded-SNI issuance hole.lib/kamal/configuration/proxy/run.rb:MINIMUM_VERSION = "v1.0.0.1"v1.0.0.1tag (bin/sync-proxy-flags --binary) — the only diff is the version stamp: v1.0.0.1 adds no deploy or run flags, so the coverage canary had nothing new to deciderun.versionexample bumped;setup.shreads the constant dynamically and needed nothingRefs #93 (workstream G)
Test plan
ghcr.io/mhenrixon/kamal-proxy:v1.0.0.1is published (amd64+arm64) — thenbin/test(full integration incl. the E4 port_holder handoff gate) before mergingbin/release-dash 3.0.0Deviations & judgment calls
docker buildx imagetools inspect(both arches) and re-runbin/sync-proxy-flagsagainst the pulled image to confirm byte-identical output.proxy_flag_coverage_test.rbmentioning v1.0.0.0 is left as-is — it describes history, not the current minimum.port_holderremains opt-in (the open decision from feat(proxy): port_holder handoff, JSON-verified reboots, LB drift detection (#93 workstream E) #97); the release notes already qualify the zero-downtime claim accordingly. Flipping the default is still a one-liner if you decide beforebin/release-dash.