fix(scanner): harvest ICON* constants assigned with .freeze - #4
Merged
Merged
Conversation
Prism models `ICONS = { … }.freeze` as a CallNode, so declaration
harvest skipped hash/array values and cross-file dynamics
(`PhosphorIcon(@ICON)` + frozen ICONS map) lost names at prune.
Unwrap zero-arg `.freeze` (and parentheses) before walking the
declaration value. Regression fixtures cover frozen hash + array
maps rendered from another file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.freeze(and parentheses) soICONS = { … }.freezeand%i[a b].freezestill contribute icon names.CallNode; without unwrapping, hash/array values were never collected.ICONSmap +PhosphorIcon(@icon)in a shared component → Dockerglyphs:prune_iconsdeleted the SVGs → productionIcons::IconNotFound(e.g. Zazu AppSignal ma-production #888 forcar/identification-badge).FrozenIconsMap+SelectableRow) and a scanner example; documents the behavior in README/CHANGELOG.No version bump — release workflow handles that.
Test plan
bundle exec rspec— 133 examples, 0 failuresStyle/MutableConstantworkaround onKycDocumentTypeOptions::ICONSif desired