Skip to content

chore(docs): bump docs-kit (all Rouge languages + later fixes) - #26

Merged
mhenrixon merged 2 commits into
mainfrom
chore/bump-docs-kit-all-languages
Jul 1, 2026
Merged

chore(docs): bump docs-kit (all Rouge languages + later fixes)#26
mhenrixon merged 2 commits into
mainfrom
chore/bump-docs-kit-all-languages

Conversation

@mhenrixon

@mhenrixon mhenrixon commented Jul 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

Bumps the pinned docs-kit revision from 19a983af331b15, picking up
everything merged into docs-kit after the initial extraction PR:

  • All Rouge languages in DocsUI::Code (no allowlist) + DocsKit.configure
    aliases/labels/fallback.
  • Reusable deploy workflow least-privilege perms + repo-linked image docs.
  • DocsUI::Section optional description; on-page toggle tree-shake fix.
  • Loader fix: ignores the gem's Rails app template under eager_load!.

Lockfile-only change.

Test plan

  • CI=true RAILS_ENV=test bundle exec rspec spec/requests spec/system8 green
    (eager_load on, matching CI)
  • bin/rubocop — clean (345 files)
  • bun run build:css rebuilds the daisyUI CSS with the renamed DocsUI kit

Summary by CodeRabbit

  • Chores
    • Updated deployment settings to use stricter, explicit permissions during documentation releases.
    • This helps prevent permission escalation while keeping the deployment process working reliably.

…xes)

Picks up everything after 19a983a: all Rouge languages in DocsUI::Code (+ config
aliases/labels/fallback), reusable-workflow least-privilege perms, DocsUI::Section
description, on-page toggle fix, and the loader fix that ignores the app template
under eager_load. 8 specs green (CI-mode eager_load); bin/rubocop clean.
@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: af9e4245-1238-45ac-bb75-6a96d0c09db3

📥 Commits

Reviewing files that changed from the base of the PR and between 1252a68 and 514e3eb.

⛔ Files ignored due to path filters (1)
  • docs/Gemfile.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • .github/workflows/deploy-docs.yml

📝 Walkthrough

Walkthrough

The deploy-docs GitHub Actions workflow now declares explicit top-level permissions (contents: read, packages: write) with a comment explaining the grant is required for the build job while avoiding permission escalation beyond the caller's granted permissions.

Changes

Workflow Permissions Update

Layer / File(s) Summary
Add explicit permissions block
.github/workflows/deploy-docs.yml
Adds a top-level permissions block granting contents: read and packages: write, with comments explaining the constraint against permission escalation.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Poem

A rabbit peeks at YAML lines,
Permissions set in tidy signs,
Read the contents, write the pack,
No more escalation on this track. 🐇✨

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly reflects the main docs-kit bump and mentions the included follow-up fixes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Comment @coderabbitai help to get the list of available commands.

@mhenrixon
mhenrixon enabled auto-merge (squash) July 1, 2026 10:34
A reusable workflow can only narrow permissions, not escalate. With the repo's
read-only default token, the build job's packages: write exceeded the grant →
startup_failure. Grant contents:read + packages:write in the caller (matches the
docs-kit + phlex-reactive callers).
@mhenrixon
mhenrixon merged commit 1eed05d into main Jul 1, 2026
8 checks passed
@mhenrixon
mhenrixon deleted the chore/bump-docs-kit-all-languages branch July 1, 2026 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant