chore(docs): bump docs-kit (all Rouge languages + later fixes) - #26
Merged
Conversation
…xes) Picks up everything after 19a983a: all Rouge languages in DocsUI::Code (+ config aliases/labels/fallback), reusable-workflow least-privilege perms, DocsUI::Section description, on-page toggle fix, and the loader fix that ignores the app template under eager_load. 8 specs green (CI-mode eager_load); bin/rubocop clean.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe deploy-docs GitHub Actions workflow now declares explicit top-level permissions (contents: read, packages: write) with a comment explaining the grant is required for the build job while avoiding permission escalation beyond the caller's granted permissions. ChangesWorkflow Permissions Update
Estimated code review effort: 1 (Trivial) | ~3 minutes Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
Comment |
mhenrixon
enabled auto-merge (squash)
July 1, 2026 10:34
A reusable workflow can only narrow permissions, not escalate. With the repo's read-only default token, the build job's packages: write exceeded the grant → startup_failure. Grant contents:read + packages:write in the caller (matches the docs-kit + phlex-reactive callers).
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the pinned docs-kit revision from
19a983a→f331b15, picking upeverything merged into docs-kit after the initial extraction PR:
DocsUI::Code(no allowlist) +DocsKit.configurealiases/labels/fallback.
DocsUI::Sectionoptional description; on-page toggle tree-shake fix.eager_load!.Lockfile-only change.
Test plan
CI=true RAILS_ENV=test bundle exec rspec spec/requests spec/system— 8 green(eager_load on, matching CI)
bin/rubocop— clean (345 files)bun run build:cssrebuilds the daisyUI CSS with the renamedDocsUIkitSummary by CodeRabbit