Repository navigation
chore(transport-matrix): name in-process suites for their boundary (ZOD098) - #147
Merged
Merged
Conversation
… test:ci runs them Rename the five transport-matrix suites that need no Docker, homeserver or socket so the *integration* exclude in test:ci stops skipping them: explicit-handoff, handoff-return and fanout (.harness), pull-transport, and workforce-publisher (.fake-fetch). Docker/Tuwunel suites keep their names. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
zooidbot
commented
Oct 15, 2026
zooidbot
left a comment
Collaborator
Author
There was a problem hiding this comment.
Reviewed against #114's acceptance criteria and ZOD098's tier table. No blocking findings.
- In-process suites run in build-test: all five renamed suites import only vitest,
node:eventsandsrc/*.workforce-publisherinjects avi.fnfetch and makes no network calls. They're tier 1, sotest:ciis the right home for them. - CI evidence: the
build-testlog lines in the body showexplicit-handoff,handoff-returnandfanout(pluspull-transportandworkforce-publisher) executed. 35/35 files passed. - Docker/Tuwunel suites:
integration,context-providerandmediakeep their names and their exclusion, so they stay with #106. - Pure renames (0/0 diff), and no
.github/workflows/change. No config or docs reference the old filenames.
Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #114
Root
test:ciexcludes**/*integration*.test.ts, so five in-processtransport-matrixsuites never ran in CI. Renamed (puregit mv, no content change):explicit-handoff.integration.test.tsexplicit-handoff.harness.test.tshandoff-return.integration.test.tshandoff-return.harness.test.tsfanout.integration.test.tsfanout.harness.test.tspull-transport.integration.test.tspull-transport.test.tsworkforce-publisher.integration.test.tsworkforce-publisher.fake-fetch.test.tsChecked each suite's imports and helpers: the five import only vitest,
node:eventsandsrc/*, with fakes injected (fake echo harness,vi.fnfetch). No Docker, Tuwunel, socket, ortests/fixtures/*.integration.test.ts,context-provider.integration.test.tsandmedia.integration.test.tsuse the Tuwunel fixture and keep their names and exclusion (zooid#106; the latter two are already intest:infra). No.github/workflows/change.Tests:
pnpm test:ci(repo root): exit 0. Scoped totransport-matrixwith the same excludes: 35 files, 460 tests passed.pnpm test:socket(repo root): exit 0. scripts 2 files / 25 tests, context-mcp 5, pi-extension 3.CI evidence (
build-testlog lines showing the three suites executed):From
build-test(run 38693909095, job 116285926904, "Test" step =pnpm test:ci): run and passed, none skipped. Both jobs green.Not verified: nothing.
Knowledge impact: none
Plan feedback: none. The issue's grep was right on all five; the only judgment call was the new names, which the issue left open.
🤖 Generated with Claude Code