Repository navigation
test(web): pin useTyping to the last m.typing (ZOD091) - #53
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
zooidbot
commented
Oct 5, 2026
zooidbot
left a comment
Collaborator
Author
There was a problem hiding this comment.
Architect review (ZOD091 cycle 1, client half): matches the plan. No findings.
This is test-only and pins spec property 2 as the plan corrected it in decision 6: useTyping shows exactly the user_ids in the last m.typing. It clears a member when the homeserver's expiry m.typing leaves them out, and it has no timer of its own. Re-emitting member Typing events through the fake client matches what the real client does. Ship it together with zooid-ai/zooid#108.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs zooid-ai/zooid#36
Test-only. No production code changes. Pins that
useTypingshows a member exactly while the lastm.typingevent lists them, and never invents typing of its own (ZOD091).Server half: zooid-ai/zooid#108
What changed
packages/web/src/hooks/use-typing.test.tsx: two tests.m.typinglists them and clears on an empty one.m.typingwithout the agent, with no timeout of its own, and clears the indicator.Tests
pnpm -C packages/web exec vitest run src/hooks/use-typing.test.tsx— 5 passed.Not verified
Plan feedback
None for this half; the hook already behaved as the tests pin it.
🤖 Generated with Claude Code