Support multiple message elements in Gmail dark theme#612
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q3HANa7VjTStHLgCT1USHa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the Gmail message dark theme handler to support multiple message elements simultaneously instead of tracking only a single element.
Summary
The dark theme message handler previously tracked a single message element and would revert its theme when a different element was encountered. This change updates it to maintain dark theme controllers for multiple message elements, enabling proper theming when multiple messages are visible in the DOM.
Key Changes
themedElementandcontrollervariables to aMap<HTMLElement, DarkThemeController>for tracking multiple elements$()(single element) to$$()(multiple elements)Setof current message elements to efficiently detect which controllers should be cleaned upImplementation Details
https://claude.ai/code/session_01Q3HANa7VjTStHLgCT1USHa