Skip to content

Don't stop scrolling on the first round that adds no results #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Benjapieres wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't stop scrolling on the first round that adds no results #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,12 @@ class Place:
opens_at: str = ""
introduction: str = ""

# Google lazy-loads the results panel, so a scroll that adds nothing is not
# proof the list ended — it usually means the next batch is still in flight.
# Only give up after this many flat rounds, waiting between each.
MAX_STAGNANT_SCROLLS = 3
SCROLL_SETTLE_MS = 1000

def setup_logging():
logging.basicConfig(
level=logging.INFO,
Expand Down Expand Up @@ -126,16 +132,25 @@ def scrape_places(search_for: str, total: int) -> List[Place]:
page.wait_for_selector('//a[contains(@href, "https://www.google.com/maps/place")]')
page.hover('//a[contains(@href, "https://www.google.com/maps/place")]')
previously_counted = 0
stagnant_rounds = 0
while True:
page.mouse.wheel(0, 10000)
page.wait_for_selector('//a[contains(@href, "https://www.google.com/maps/place")]')
found = page.locator('//a[contains(@href, "https://www.google.com/maps/place")]').count()
logging.info(f"Currently Found: {found}")
if found >= total:
logging.info(f"Currently Found: {found}")
break
if found == previously_counted:
logging.info("Arrived at all available")
break
stagnant_rounds += 1
if stagnant_rounds >= MAX_STAGNANT_SCROLLS:
logging.info(f"Arrived at all available: {found}")
break
# The count only settles once the lazy-loaded batch lands, so
# wait before treating a flat round as the end of the list.
page.wait_for_timeout(SCROLL_SETTLE_MS)
else:
stagnant_rounds = 0
logging.info(f"Currently Found: {found}")
previously_counted = found
listings = page.locator('//a[contains(@href, "https://www.google.com/maps/place")]').all()[:total]
listings = [listing.locator("xpath=..") for listing in listings]
Expand Down