Fix include order in server_util.c for modern glibc compatibility#290
Open
seriv wants to merge 1 commit into
Open
Fix include order in server_util.c for modern glibc compatibility#290seriv wants to merge 1 commit into
seriv wants to merge 1 commit into
Conversation
On systems with newer glibc (e.g. RHEL 10), including <sys/wait.h> before amanda.h causes a build failure: gnulib's signal.h is pulled in transitively before config.h is set up, triggering: gnulib/unistd.h: #error "Please include config.h first." amanda.h must be the first include in any Amanda source file, as it sets up config.h via ../config/config.h. Move it above <sys/wait.h>. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#include "amanda.h"above#include <sys/wait.h>inserver-src/server_util.cOn modern glibc (as found on RHEL 10 / glibc 2.39+), including
<sys/wait.h>beforeamanda.htriggers a build failure:
The include chain is:
server_util.cincludes<sys/wait.h>-I../gnulibinterceptssignal.h, pulling in gnulib's wrapper#include_next <signal.h>→bits/sigstksz.hunistd.hbeforeconfig.hhas been processedamanda.hincludesconfig.has its first action. Moving it first satisfies gnulib's requirement.Test plan
🤖 Generated with Claude Code