eth: drop redundant filter API registration#25
Merged
will-2012 merged 1 commit intoJul 14, 2026
Conversation
flywukong
changed the title
will-2012
approved these changes
Jul 13, 2026
zlacfzy
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix issue of [API] eth/filters.NewFilterAPI bool .
1)remove the duplicate eth filter API registration from eth/backend.go
2)rely on cmd/utils.RegisterFilterAPI as the single registration path
3)preserve the configured filters.Config.RangeLimit instead of implicitly using an empty configuration
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes: