feat: list top chargeback merchant groups - #5
Conversation
|
Review summary:
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5821cad3fa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| }, | ||
| "membership": { | ||
| "description": "Maker wallets with at least $10,000 in fulfilled volume summed across PayPal, Venmo, and Cash App for all available history, excluding manual releases. There is no date cutoff and this initialization cohort is not periodically refreshed.", |
There was a problem hiding this comment.
Record the one-time evaluation timestamp
Once a maker crosses the threshold after initialization, the no-date-cutoff criterion says that wallet qualifies while the explicitly non-refreshed cohort will continue to exclude it. Record the snapshot/as-of timestamp for this one-time calculation, in both the production and staging metadata, so the published membership predicate remains accurate and reproducible.
Useful? React with 👍 / 👎.
| "groupId": "0xdf1c64c54745aa1ce00642a5874f97e3183bf5e993c1f559d0a37a4df0b803c7", | ||
| "name": "Top Chargeback Merchants", | ||
| "slug": "top-chargeback-merchants", | ||
| "description": "One-time cohort of makers with at least $10,000 in all-time non-manual-release PayPal, Venmo, or Cash App volume.", |
There was a problem hiding this comment.
The intended threshold is 10,000 USDC, but this describes it as $10,000, which denotes a USD amount rather than an exact token quantity. If USDC deviates from $1 or an evaluator reconstructs eligibility using token units, these are different predicates; identify the threshold as 10,000 USDC here and in the staging metadata.
Useful? React with 👍 / 👎.
Summary
Onchain verification
Validation