chore: remove obsolete historical tier listings - #4
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e2066a923
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| branches: | ||
| - main | ||
| - releases/staging | ||
| workflow_dispatch: |
There was a problem hiding this comment.
Removing the staging branch from the push filter does not prevent a maintainer from selecting releases/staging when invoking the remaining workflow_dispatch. In that scenario, actions/checkout builds this ref—which now contains zero group manifests—and the schema permits the empty list, so the deploy step can still overwrite the canonical Pages artifact with groups: []. Remove manual dispatch or add a job-level guard restricting deployments to refs/heads/main.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in b856d63: removed workflow_dispatch from the retired release ref as well, so it cannot publish through either pushes or manual dispatches. The canonical main workflow remains unchanged.
|
Codex review cycle 1: fixed the manual-dispatch publication edge in b856d63. No findings deferred or rejected. Local |
|
@codex review |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
releases/stagingas a GitHub Pages publication trigger so this stale ref cannot overwrite the canonical listSafety
mainis unchanged and retains all six chargeback-only staging/production entriesValidation
npm run check(0 obsolete groups on this retired ref)maincontains only the six canonical chargeback-only groups