Skip to content

feat(rust): native component move, rename and deprecation - #274

Merged
zkochan merged 4 commits into
rust-workspace-materializationfrom
rust-client-identity
Oct 18, 2026
Merged

zkochan merged 4 commits into
rust-workspace-materializationfrom
rust-client-identity

Conversation

@zkochan

@zkochan zkochan commented Oct 17, 2026 •

Copy link
Copy Markdown
Owner

Move component relocation, rename, deprecation and undeprecation into the Rust client VCS engine. Related to #73; this targets rust-workspace-materialization, which feeds teambit#10813.

Rust owns source inventory, identity and path selection, refactoring, file materialization, package/link publication, configuration and bitmap history. A retained published Harmony session supplies real providers, component classes, onLoad/package callbacks, onComponentAdd and compiler tooling. AST refactoring uses the published transformer through private filesystem spools.

Preserve Node 2.2.94 lifecycle behavior, including provider mutations, callback-only source changes, component-level refactor writes, exported/lane provenance, cache invalidation, ignored-file cleanup, default component directories and partial failures. Unsupported inputs delegate before effects; native failures after effects never replay the command. Scope/owner rename remains a separate documented fallback.

Validation:

  • All seven required local checks pass: formatting, Clippy, custom lints, rustdoc, 1,390 workspace tests (one existing ignored), 641 e2e tests and the port inventory check. The branch also passes the Rust scope check.
  • Adds 49 operation and lifecycle e2e cases, mapping 73 active upstream assertions. Strict same-path comparisons include output, files, modes, links, caches and complete retained history snapshots; fixture replay preserves hardlinks and modification times.
  • Benchmark evidence measured at 50ac1ea7c records 210 passing pairs against Node 22.22.0 / Bit 2.2.94: five alternating pairs in non-TTY, CI and TTY modes. All 40 native workload/mode medians are faster; ten intentionally delegated CI error pairs are excluded from native speed claims. The five identity workloads use about 4–33% less median elapsed time on these fixtures. Status, checkout, export and six ADD workloads also retain parity.
  • Each complete workload was independently qualified after 20 seconds below 30% aggregate host CPU use, with a closed 0.5-second monitor staying below 80%. Records retain source/binary/helper/fixture fingerprints, raw counters, the qualification driver and invalid contended attempts. These are warm-metadata, Linux file-remote measurements, without first-use, network-remote or cross-platform speed claims.

The follow-up fixes preserve per-writer LF/CRLF handling, exact dependency-graph path aliases, the pinned Windows nested-move failure, and exported rename’s add/retire/reload/refactor order. Retained rows carry scoped/default-scope metadata even without custom onLoad hooks; a negative control reproduces the incorrect exported manifest when that metadata is omitted. The partial hub acknowledgment fixture now selects a deterministic returned ID without changing published persistence or state comparisons.

Broader patterned removal/recovery and scope/owner rename remain for the next substantial tracking/mutation chunk; this does not close #73.

The final Windows fixture correction promotes only versioned, requested export rows and asserts that new components retain all bitmap fields. Doctor retains its strict eight-diagnosis/seven-request checks and now reports captured transport errors on failure. These changes affect tests only; production sources and the measured release binary remain unchanged from the qualified source.

@zkochan
zkochan merged commit 0b975b0 into rust-workspace-materialization Oct 18, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant