Repository navigation
feat(rust): native component move, rename and deprecation - #274
Merged
Merged
Conversation
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move component relocation, rename, deprecation and undeprecation into the Rust client VCS engine. Related to #73; this targets
rust-workspace-materialization, which feeds teambit#10813.Rust owns source inventory, identity and path selection, refactoring, file materialization, package/link publication, configuration and bitmap history. A retained published Harmony session supplies real providers, component classes, onLoad/package callbacks, onComponentAdd and compiler tooling. AST refactoring uses the published transformer through private filesystem spools.
Preserve Node 2.2.94 lifecycle behavior, including provider mutations, callback-only source changes, component-level refactor writes, exported/lane provenance, cache invalidation, ignored-file cleanup, default component directories and partial failures. Unsupported inputs delegate before effects; native failures after effects never replay the command. Scope/owner rename remains a separate documented fallback.
Validation:
50ac1ea7crecords 210 passing pairs against Node 22.22.0 / Bit 2.2.94: five alternating pairs in non-TTY, CI and TTY modes. All 40 native workload/mode medians are faster; ten intentionally delegated CI error pairs are excluded from native speed claims. The five identity workloads use about 4–33% less median elapsed time on these fixtures. Status, checkout, export and six ADD workloads also retain parity.The follow-up fixes preserve per-writer LF/CRLF handling, exact dependency-graph path aliases, the pinned Windows nested-move failure, and exported rename’s add/retire/reload/refactor order. Retained rows carry scoped/default-scope metadata even without custom onLoad hooks; a negative control reproduces the incorrect exported manifest when that metadata is omitted. The partial hub acknowledgment fixture now selects a deterministic returned ID without changing published persistence or state comparisons.
Broader patterned removal/recovery and scope/owner rename remain for the next substantial tracking/mutation chunk; this does not close #73.
The final Windows fixture correction promotes only versioned, requested export rows and asserts that new components retain all bitmap fields. Doctor retains its strict eight-diagnosis/seven-request checks and now reports captured transport errors on failure. These changes affect tests only; production sources and the measured release binary remain unchanged from the qualified source.