Skip to content

Update OZ contracts to version 5.2.0 and remove solidity-stringutils dependency#13

Merged
shreyas-londhe merged 2 commits into
zkemail:mainfrom
ernestognw:chore/remove-stringutils
Jul 18, 2025
Merged

Update OZ contracts to version 5.2.0 and remove solidity-stringutils dependency#13
shreyas-londhe merged 2 commits into
zkemail:mainfrom
ernestognw:chore/remove-stringutils

Conversation

@ernestognw

@ernestognw ernestognw commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

Description

Required for OpenZeppelin/openzeppelin-community-contracts#182

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have discussed with the team prior to submitting this PR
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

@ernestognw ernestognw changed the title Update @openzeppelin/contracts to version 5.2.0 and remove solidity-s… Update OZ contracts to version 5.2.0 and remove solidity-stringutils dependency Jul 9, 2025
@ernestognw
ernestognw marked this pull request as ready for review July 9, 2025 14:49
@ernestognw
ernestognw marked this pull request as draft July 10, 2025 15:01
@ernestognw

Copy link
Copy Markdown
Contributor Author

Need to validate tests are working properly before it's ready

@ernestognw

Copy link
Copy Markdown
Contributor Author

Gas diff:

-JwtRegistryTest_stringToArray:test_stringToArray() (gas: 28540)
+JwtRegistryTest_stringToArray:test_stringToArray() (gas: 10981)

@ernestognw
ernestognw marked this pull request as ready for review July 11, 2025 19:20
@shreyas-londhe
shreyas-londhe merged commit e253337 into zkemail:main Jul 18, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants