Add tests for bogus handling of UTF-16#672
Open
WhyNotHugo wants to merge 1 commit into
Open
Conversation
These need review, but I'm pretty sure that the tests are correct and that our logic is broken for these edge cases.
Member
|
Had an initial look. I think I'm following along with the tests correctly... But I'm not so knowledgeable in the underlying issue of byte offsetting.. So it's confidence on shaky legs. Most likely your tests are correct though, and the underlying function implementation is buggy. I'm pretty sure this offset solution was added in #317 (or this at least touched the underlying code meaningfully). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These need review, but I'm pretty sure that the tests are correct and that our logic is broken for these edge cases.