fix(op): guard against nil claims for opaque access tokens in token exchange - #959
Open
ChrisJr404 wants to merge 1 commit into
Open
fix(op): guard against nil claims for opaque access tokens in token exchange#959ChrisJr404 wants to merge 1 commit into
ChrisJr404 wants to merge 1 commit into
Conversation
…xchange Exchanging an opaque access token (an encrypted tokenID:subject string) panicked, because getTokenIDAndClaims returns nil claims with ok true and the caller dereferenced them unconditionally. Skip the dereference when there are no claims and add a test covering that path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #704.
Doing a token exchange with an opaque access token panics. When the token is an encrypted tokenID:subject string rather than a JWT, getTokenIDAndClaims returns nil claims with ok true, and GetTokenIDAndSubjectFromToken then dereferences that nil pointer on accessTokenClaims.Claims.
I added a nil guard so opaque tokens come back with empty claims (there are no JWT claims to read in that case), and a test for the opaque path since, as the issue mentions, it wasn't covered before.