feat(oidc,client): Adds support for OpenID Key Binding to client - #943
Open
EthanHeilman wants to merge 3 commits into
Open
feat(oidc,client): Adds support for OpenID Key Binding to client#943EthanHeilman wants to merge 3 commits into
EthanHeilman wants to merge 3 commits into
Conversation
4 tasks
EthanHeilman
marked this pull request as ready for review
August 12, 2026 20:33
Contributor
Author
|
@wim07101993 How much interest is there in merging this? Do you want me to move this to v4 rather v3? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Problems Are Solved
This PR adds client support for OpenID Key Binding 1.0 a draft standard for Proof-of-Possession ID Tokens. Basically ID Tokens that have a public key enabling the user to sign under their identity.
OpenPubkey supports key binding using zitadel/oidc as the library. However because zitadel/oidc does not natively support key binding, OpenPubkey has to use a fragile rounder-tripper work around for the RP.
This PR allows key binding support for OP and RP:
This PR is only for client/RP. It does not add key binding to the OP code. I would like to add that at a future point, but client/RP support the main blocker to using plain zitadel/oidc with key binding.
I've run manual tests for code flow, refresh and device flow using the key binding with the Hello OP and this PR in OpenPubkey that runs against this branch: openpubkey/openpubkey#395
How the Problems Are Solved
Adds a
WithKeyBindingoption to RP so that the RP can request key bound ID Tokens from the OP and aKeyBindingRelyingPartyto perform the additional steps used by key binding.Additional Changes
No additional changes
Additional Context
Do you want me to port this to v4 as well as v3?
Relevant PRs