docs: added documentation which explains why blindly upgrading otel dependencies might introduce bugs with xk6-modules - #939
Open
wim07101993 wants to merge 5 commits into
Open
Conversation
…pendencies might introduce bugs with xk6-modules
Contributor
There was a problem hiding this comment.
Pull request overview
This PR documents and enforces a constraint around OpenTelemetry dependency upgrades to prevent breaking downstream zitadel/xk6-modules builds that depend on both this library and grafana/k6.
Changes:
- Added contributor documentation describing why OpenTelemetry upgrades must not get ahead of the latest tagged k6 release, and how to verify compatibility.
- Added a GitHub Actions workflow to enforce the “otel not ahead of k6” rule on PRs and key branches.
- Added a bash script that compares this repo’s
go.opentelemetry.io/otel*requirements with those pinned by the latest k6 release on the major line used byxk6-modules.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| CONTRIBUTING.md | Adds guidance and verification steps for safe OpenTelemetry dependency bumps (k6/xk6-modules compatibility). |
| .github/workflows/otel-k6-compat.yml | Introduces CI enforcement to fail PRs that upgrade otel beyond the latest tagged k6 release. |
| .github/scripts/check-otel-k6-compat.sh | Implements the compatibility check by resolving the relevant k6 tag and comparing pinned otel versions. |
Suppressed comments (1)
.github/scripts/check-otel-k6-compat.sh:56
- Same as above: add curl retries/timeouts to reduce CI flakiness when fetching k6's go.mod from raw.githubusercontent.com.
theirs=$(curl -sSfL "$(printf "$K6_GOMOD_URL" "$k6_tag")" | otel_versions | head -1)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which Problems Are Solved
Upgrading otel dependencies would sometimes break xk6-modules of our load tests.
How the Problems Are Solved
Additional Changes
Additional Context