added default argument loader - #1188
Merged
Sonal (sonalgoyal) merged 3 commits intoAug 11, 2025
Merged
Conversation
Sonal (sonalgoyal)
requested changes
Aug 7, 2025
| } | ||
|
|
||
| @Override | ||
| public A load(String path) throws ZinggClientException, InstantiationException, IllegalAccessException, NoSuchMethodException, InvocationTargetException { |
Member
There was a problem hiding this comment.
wrong practise of passing arg and not using it in the method
Contributor
Author
There was a problem hiding this comment.
It was made as default method of abstract class(so, it was not breaking Liskov's substitution) but anyways removed it.
Nitish (Nitish1814)
added a commit
to Nitish1814/zingg-Nitish
that referenced
this pull request
Aug 17, 2025
* added default argument loader * added Type in <> operator * removed default loader --------- Co-authored-by: Nitish <nitish.joshi1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.