Fix squeezed single-particle trajectories in ZnVis - #61
Open
jdrotleff wants to merge 5 commits into
Open
Conversation
This PR fixes a crash that occurs when ZnVis receives a single particle or vector field without an explicit entity dimension, e.g. `(n_times, 3)` instead of `(n_times, 1, 3)`. ZnVis already handled one-entity trajectories correctly when the particle dimension was preserved. The bug only showed up when that dimension was squeezed away. Normalize squeezed particle/vector-field frames with `np.atleast_2d`. Add regression coverage in the existing CI integration tests for: - single-particle trajectories - single-vector-field trajectories
jdrotleff
force-pushed
the
fix/single_particle_trajectories
branch
from
July 10, 2026 12:54
facf8be to
abfbf61
Compare
jdrotleff
marked this pull request as draft
July 10, 2026 12:56
jdrotleff
marked this pull request as ready for review
July 10, 2026 13:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash that occurs when ZnVis receives a non-static single particle or vector field without an explicit entity dimension, e.g.
(n_times, 3)instead of(n_times, 1, 3). ZnVis already handled one-entity trajectories correctly when the entity axis was preserved. The bug only showed up when that axis was squeezed away.Normalize squeezed dynamic particle and vector-field frames by restoring the entity axis. Add regression coverage in the existing CI integration tests for single-particle trajectories and single-vector-field trajectories.