chore(core): drop unused glob and faiss-node dependencies - #416
Open
SomSamantray wants to merge 2 commits into
Open
chore(core): drop unused glob and faiss-node dependencies#416SomSamantray wants to merge 2 commits into
SomSamantray wants to merge 2 commits into
Conversation
…ch#377) Both packages were declared as direct dependencies of @zilliz/claude-context-core but are not imported anywhere in the repository. glob@10 is itself deprecated, and faiss-node pulls in the deprecated prebuild-install, so removing them clears two of the six npm warn deprecated lines reported in issue zilliztech#377 for downstream consumers (verified via npm pack + consumer install). The remaining warnings (q, node-domexception, uuid) come from upstream major versions (milvus2-sdk-node 2.x, langchain 0.3.x, genai 1.x) and are not addressable without breaking bumps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fresh
npm installof the published MCP package no longer emits deprecation warnings forglobandprebuild-install— two of the six warnings a new install reports. Both packages were declared as direct dependencies of@zilliz/claude-context-corebut are not imported anywhere in the repository, so removing them is zero-risk and supersedes bumpingglobto^11. The remaining warnings (q,node-domexception,uuid) come from upstream major-version chains (milvus2-sdk-node 2.x, langchain 0.3.x, genai 1.x) and are out of scope without breaking bumps.Validation: core build, typecheck, and 29/29 tests pass;
npm packof the core tarball followed by a fresh consumernpm installshows both warnings gone.Related: #377
Session-settled decisions carried from planning: remove unused dependencies instead of bumping them (user-approved, over bumping
globto^11).