Repository navigation
Conversation
- Add DiskANN config, CLI options, and native SDK parameter mappings - Support DiskANN config serialization and preserve HNSW defaults - Validate collection reuse, insert results, and index completeness - Add regression tests and opt-in Linux native smoke test - Document separate index build and search-only workflows Signed-off-by: Wayne Gao <wayne.gao1@solidigm.com>
- Skip close() after successful destruction during index rebuild - Preserve cleanup and abort recreation when destruction fails - Add regression tests for successful and failed destruction Signed-off-by: Wayne Gao <wayne.gao1@solidigm.com>
Author
|
/approve |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gaowayne The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Author
|
/assign xuanyang-cn |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add DiskANN support to the Zvec backend, reusing VectorDBBench's existing dataset, loading, search, recall, latency, and result-reporting workflows.
HNSW remains the default.
Changes
ZvecDiskANNIndexConfigand support restoring DiskANN configurations from saved results.--index-type diskannwith separate construction, search, and PQ parameters.DiskAnnIndexParamandDiskAnnQueryParam.close()after successful collection destruction.Validation
Validated on Linux with Python 3.12.3:
Cohere 10M Search Results
Configuration: 768 dimensions, COSINE, R=64, build list=100, PQ=96,
search list=300, K=100, nq=1, and IDs-only responses.
Concurrent search was tested at 12, 14, 16, 18, and 20 processes,
with a 300-second measurement window per configuration.
Scope and Limitations
Collection.close()support.