Repository navigation
feat(lancedb): enable GooseFS in the UI and add IVF_FLAT/SQ/RQ/BTree indexes - #870
Open
XuQianJin-Stars wants to merge 4 commits into
Open
XuQianJin-Stars wants to merge 4 commits into
XuQianJin-Stars wants to merge 4 commits into
Conversation
Share GooseFS/COS storage_options resolution so UI and CLI both pick up GOOSEFS_* env vars, expose IVF_HNSW_SQ/PQ in Run Test, allow concurrent loads, and reuse existing icons for DBs without dedicated assets.
…torage_options
Return PartialInsertError for already-committed fragment prefixes so
ConcurrentInsertRunner does not retry whole batches, and treat
storage_options={} as an explicit empty mapping.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: XuQianJin-Stars The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
Author
|
hi @XuanYang-cn all checks have passed and there are no conflicts. Could you help review this PR when you get a chance? Thanks! |
XuQianJin-Stars
force-pushed
the
feat/lancedb-goosefs-ui-support
branch
2 times, most recently
from
September 11, 2026 10:17
cb733b0 to
9e9efba
Compare
Wire Lance BTree through CLI (`lancedbbtree`), UI, and create_index so filter cases can use a scalar index on id/label.
XuQianJin-Stars
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
storage_optionsin the LanceDB Run Test UI (sameGOOSEFS_*/ COS env resolution as CLI) and fill missing DB icons.lancedbivfflat/lancedbivfsq/lancedbivfrq), and UI index options. IVF_HNSW_SQ/PQ remain available.PartialInsertErrorafter a partially committedtable.addso concurrent load does not retry already-written IDs; treatstorage_options={}as an explicit empty mapping.Test plan
make formatandmake lintpasstests/test_lancedb_config.pyandtests/test_lancedb_client.pypassstorage_optionsfilled from env; index dropdown includes IVF_FLAT, IVF_PQ, IVF_SQ, IVF_RQ, IVF_HNSW_SQ, IVF_HNSW_PQvectordbbench lancedbivfflat|lancedbivfsq|lancedbivfrq --helpshows the new commands