Skip to content

fix lint issues; remove client dependency from runner #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
XuanYang-cn merged 1 commit into from
Nov 26, 2025
+2 −3
Merged

fix lint issues; remove client dependency from runner #645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion vectordb_bench/backend/clients/cockroachdb/cockroachdb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class CockroachDB(VectorDB):
FilterOp.StrEqual,
]

def __init__(
def __init__( # noqa: PLR0915
self,
dim: int,
db_config: dict,
Expand Down
3 changes: 1 addition & 2 deletions vectordb_bench/backend/runner/rate_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@

from vectordb_bench import config
from vectordb_bench.backend.clients import api
from vectordb_bench.backend.clients.doris.doris import Doris
from vectordb_bench.backend.dataset import DataSetIterator
from vectordb_bench.backend.utils import time_it

Expand Down Expand Up @@ -54,7 +53,7 @@ def _insert_embeddings(db: api.VectorDB, emb: list[list[float]], metadata: list[
db_copy = deepcopy(db)
with db_copy.init():
_insert_embeddings(db_copy, emb, metadata, retry_idx=0)
elif isinstance(db, Doris):
elif db.name == "Doris":
# DorisVectorClient is not thread-safe. Similar to pgvector, create a per-thread client
# by deep-copying the wrapper and forcing lazy re-init inside the thread.
db_copy = deepcopy(db)
Expand Down