Split off ZHA diagnostics files without an original signature#803
Open
puddly wants to merge 9 commits into
Open
Split off ZHA diagnostics files without an original signature#803puddly wants to merge 9 commits into
puddly wants to merge 9 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #803 +/- ##
==========================================
- Coverage 97.29% 97.27% -0.02%
==========================================
Files 55 55
Lines 10933 10935 +2
==========================================
Hits 10637 10637
- Misses 296 298 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Comment on lines
+115
to
+119
| if not self.is_supported(): | ||
| # `self.is_on` can raise if an attribute is missing | ||
| self._state = False | ||
| else: | ||
| self._state = self.is_on |
Contributor
There was a problem hiding this comment.
I thought this was just #788 at first but that's something different. Then thought this should be a separate PR. But looking at the code, we never read self._state – it's only ever set. I think we can just remove self._state entirely then? is_on does access the attribute value directly, like all other entities (but that's guarded by is_supported() then).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Effectively, device dumps sourced from diagnostics prior to ZHA having
original_signatureare separated out intolegacy_devices/. Everything indevices/should be accurate (for the most part, not accounting for ZCL attribute mutation).The diff will display strangely but the individual commits should make the changes clear.