Skip to content

Split off ZHA diagnostics files without an original signature#803

Open
puddly wants to merge 9 commits into
zigpy:devfrom
puddly:puddly/legacy-diagnostics-split
Open

Split off ZHA diagnostics files without an original signature#803
puddly wants to merge 9 commits into
zigpy:devfrom
puddly:puddly/legacy-diagnostics-split

Conversation

@puddly

@puddly puddly commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Effectively, device dumps sourced from diagnostics prior to ZHA having original_signature are separated out into legacy_devices/. Everything in devices/ should be accurate (for the most part, not accounting for ZCL attribute mutation).

The diff will display strangely but the individual commits should make the changes clear.

Copilot AI review requested due to automatic review settings June 25, 2026 22:27
@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.27%. Comparing base (a0e3195) to head (2ffa1ca).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #803      +/-   ##
==========================================
- Coverage   97.29%   97.27%   -0.02%     
==========================================
  Files          55       55              
  Lines       10933    10935       +2     
==========================================
  Hits        10637    10637              
- Misses        296      298       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@TheJulianJES TheJulianJES self-requested a review June 25, 2026 22:40
Comment on lines +115 to +119
if not self.is_supported():
# `self.is_on` can raise if an attribute is missing
self._state = False
else:
self._state = self.is_on

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this was just #788 at first but that's something different. Then thought this should be a separate PR. But looking at the code, we never read self._state – it's only ever set. I think we can just remove self._state entirely then? is_on does access the attribute value directly, like all other entities (but that's guarded by is_supported() then).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants