favour ArrayList over ArrayListUnmanaged#25958
Merged
Merged
Conversation
Contributor
Author
|
The failed test on Windows seems unrelated to my changes. Does anyone have any idea what could be causing it? |
Member
#22510, will restart that job if it fails again |
Member
|
FYI there's no need to continually rebase unless there are conflicts that need to be resolved (unsure if there were conflicts before the latest rebase, just letting you know). |
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make ArrayListUnmanaged ready for removal from the standard library.
zig/lib/std/std.zig
Lines 57 to 58 in f0a3df9
I have left two instances of 'ArrayListUnmanaged' unchanged:
zig/tools/std_gdb_pretty_printers.py
Lines 6 to 14 in f0a3df9
So, the tool can still be used when working with older Zig code.
zig/lib/std/std.zig
Lines 57 to 58 in f0a3df9
ArrayListUnmanaged is still available, and it is up to the project maintainers to decide when to delete it.