Fix temporary variable naming collision when using translate-c with __builtin_convertvector.#24029
Closed
Rokannon wants to merge 2 commits into
Closed
Fix temporary variable naming collision when using translate-c with __builtin_convertvector.#24029Rokannon wants to merge 2 commits into
translate-c with __builtin_convertvector.#24029Rokannon wants to merge 2 commits into
Conversation
translate-c with __builtin_convertvector.
Author
|
One check has failed with the following error: I don't think it is releated to the change done in this pull request. I can see the same failure in some other PRs. |
… `__builtin_convertvector`. Fixes #23999.
…convertvector` funcion is used.
Member
|
Closing since we've switched to Aro-based translate-c as of #24497. Contributions to translate-c should now be opened on https://github.com/ziglang/translate-c. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ziglang/translate-c#50.
The root cause of this issue was that the expression passed into the
__builtin_convertvectorupon translation into zig code was evaluated for every component of vector. This means that if expression itself uses temporary variables, then they could conflict with the ones used in the implementation of__builtin_convertvector.In this change we introduce a temporary variable which now holds the expression. Also a test was added to excercise this behavior and ensure that no collisions occur in the previously faulty scenario.