translate-c: fix applying struct alignment to first field#23863
translate-c: fix applying struct alignment to first field#23863xdBronch wants to merge 1 commit into
Conversation
|
failures feel obvious in hindsight but i believe stuff was getting cached so i didnt get any failures locally. this will need a check against the fields natural alignment which i wasnt able to figure out before, would appreciate some guidance there. |
|
Looks like you want Lines 2463 to 2465 in bc3c50c You'll just want to add a corresponding declaration on the Zig side here: Lines 164 to 167 in bc3c50c And use that to get the field type's natural alignment. |
squash before merge, waiting on ziglang/zig#23863 so the tests will pass then ill merge
|
apologies for not finishing this, the logic ended being somewhat tedious and i ended up forgetting about it. im going to just close this since its already properly done in https://github.com/ziglang/translate-c + #24432 (comment) |
fixes ziglang/translate-c#53, fixes ziglang/translate-c#69