Conversation
- release.sh 删除维护 latest/dev-latest 软连接目录的代码段 - /remote-release 命令文档同步删除"维护 latest 软链接"步骤 - 该特性从未被 install.sh/install.ps1/upgrade 模块引用,属隐式契约 - 远端历史 latest/dev-latest 目录已一并清理(仅含软连接,未影响产物)
- install.sh master 分支不稳定,导致 v2.12.2 校验和不匹配 - 改用官方 golangci/golangci-lint-action@v8,pin 版本 v2.12.2 - 自带缓存,更稳定可靠
- 安装脚本 Python 检测改为 python3 → 宝塔内置 python3 → python → python2 顺序,CentOS 7 默认仅 python2 时也可用 - 修复版本号 grep 回落(grep -o ... -A 5 不生效),改为 awk 按通道精确定位 latest,避免空版本拼出错误下载 URL - 空版本号显式拦截,normalize_version 不再返回单个 v - 配置写入 Python 改为 py2/py3 通用字节流写法,避免 io.open(encoding=) 在 py2 下不一致 - 已安装版本正则补点号,支持 0.3.12-beta.1 这类预发布号 - 下载失败时不再吞掉 curl 错误输出,便于诊断
- detector 验证 BinaryPath 解析出的 exe 文件存在性,拒绝已卸载/路径失效的服务注册 - detector 比对运行中 nginx.exe/httpd.exe 进程的 ExecutablePath 与服务 BinaryPath, 不一致则跳过 winsvc 路径(修复用户用 start nginx 跑了另一个目录的 nginx, 却被宝塔残留的 nginx 服务命中、走 SCM Stop+Start 失败的场景) - 哨兵格式扩展为 winsvc:<服务名>|<reload 命令>,承载 SCM 失败时的回退命令; 旧格式 winsvc:<服务名>(无 fallback)保持兼容 - Base.ReloadService 改为三层回退:SCM Stop+Start → fallback reload 命令 → 按错误白名单走进程重启,错误链保留前置 SCM 错误便于排查 - 抽出跨平台 helper extractServiceExePath/normalizeWindowsPath,支持引号包裹路径、 带参数、UNC 前缀、大小写不敏感比较 - 补充 winsvc 多路径单测(SCM 成功 / SCM 失败 fallback 成功 / 双失败 / 旧格式兼容)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
golangci-lintinstall.sh 安装方式,改用golangci/golangci-lint-action@v8action,避免上游脚本 checksum 漂移导致 lint job 失败latest软链接维护逻辑/remote-release远程发布指令文档Commits