This corrects a problem of resource cleanup (file deletion) in unit tests. - #172
Open
vvdb-architecture wants to merge 1 commit into
Open
This corrects a problem of resource cleanup (file deletion) in unit tests.#172vvdb-architecture wants to merge 1 commit into
vvdb-architecture wants to merge 1 commit into
Conversation
- MissingFile_IsRejectedWithCurrentModelStillLoaded - SuccessfulReload_SwapsAndDisposesPreviousModel - TruncatedGguf_IsRejectedWithCurrentModelStillLoaded - TruncatedMmProj_IsRejectedWithCurrentModelStillLoaded - FailedLoad_RestoresPreviousModel - NonGgufFile_IsRejectedWithCurrentModelStillLoaded ... which fail while executing Directory.Delete(_dir, recursive: true) with the error: "System.IO.IOException: The process cannot access the file '...' because it is being used by another process" The reason is that for all tests except `NonGgufFile_IsRejectedWithCurrentModelStillLoaded`, files are kept open by the `ModelLifecycleService', which is not disposed in the tests. For `NonGgufFile_IsRejectedWithCurrentModelStillLoaded`, the `GgufReader` constructor might throw an exception during parsing, which causes Dispose() never to be called and therefore the file never to be closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This corrects a problem in 6 unit tests:
MissingFile_IsRejectedWithCurrentModelStillLoadedSuccessfulReload_SwapsAndDisposesPreviousModelTruncatedGguf_IsRejectedWithCurrentModelStillLoadedTruncatedMmProj_IsRejectedWithCurrentModelStillLoadedFailedLoad_RestoresPreviousModelNonGgufFile_IsRejectedWithCurrentModelStillLoaded... which fail while executing Directory.Delete(_dir, recursive: true) with the error:
The reason is that for all tests except
NonGgufFile_IsRejectedWithCurrentModelStillLoaded, files are kept open by theModelLifecycleServicewhich is not disposed in the tests. ForNonGgufFile_IsRejectedWithCurrentModelStillLoaded, theGgufReaderconstructor might throw an exception during parsing, which causesDispose()never to be called and therefore the file never to be closed.