Added check for missing and extra dependencies based on installed packages#2198
Open
andy-maier wants to merge 1 commit into
Open
Added check for missing and extra dependencies based on installed packages#2198andy-maier wants to merge 1 commit into
andy-maier wants to merge 1 commit into
Conversation
Collaborator
|
coverage: 77.19%. remained the same — andy/check-all-missing into master |
andy-maier
force-pushed
the
andy/check-all-missing
branch
13 times, most recently
from
0311cd7 to
3be3f7b
Compare
andy-maier
changed the title
andy-maier
force-pushed
the
andy/check-all-missing
branch
2 times, most recently
from
7f2511b to
cc34b13
Compare
This was referenced Jun 21, 2026
Open
andy-maier
force-pushed
the
andy/check-all-missing
branch
6 times, most recently
from
bacf8c1 to
94e4994
Compare
andy-maier
force-pushed
the
andy/check-all-missing
branch
7 times, most recently
from
0f67195 to
e70bdba
Compare
…kages Details: * Extended the checks in 'make check_reqs' by a check that reports 'extra' packages. These are packages are specified in the minimum constraint files but are not installed. * Added a 'check_reqs_install' make target which performs the check for missing and extra packages for the minimum-cinstraints-install.txt file. and updated the test workflow to run that check after the initial package installation. * Removed the use of pip-missing-reqs on the packages of the development commands because that is covered by the existing check for missing packages in 'make check_reqs'. * Fixed missing and some extra packages in minimum-constraints files Signed-off-by: Andreas Maier <maiera@de.ibm.com>
andy-maier
force-pushed
the
andy/check-all-missing
branch
from
e70bdba to
a96a8c1
Compare
| }, \ | ||
| { \ | ||
| \"os\": \"windows-latest\", \ | ||
| \"python-version\": \"3.12\", \ |
Contributor
There was a problem hiding this comment.
Why did you pick a python version in the middle of the supported range?
| - name: Display extra dependencies in minimum-constraints-install.txt | ||
| shell: bash | ||
| run: | | ||
| files=(extra_reqs_install/*.txt); \ |
Contributor
There was a problem hiding this comment.
Could we reuse the checks in the make files here in some way?
EdGue42
reviewed
Jun 22, 2026
EdGue42
left a comment
EdGue42
left a comment
Contributor
There was a problem hiding this comment.
I am wondering, shouldn't the new make file targets be mentioned in the developer documentation?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.