fix(workflow): hard-gate import table check and redo-same-step (#65) - #67
Merged
Conversation
…65) - radare2/ida-reverse/malware-analysis: MUST record imports as Evidence before next phase - re-agent-workflow: triage gate blocks Dynamic without imports summary - RULES (+zh) and agent-obedience: redo named step X, no substitute
Collaborator
Author
|
本地合并流程已完成:
按协作者约定:本地合并 + 测试通过后再上线。 |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue #65 (problem 1): models could skip import-table inspection, and when asked to redo that step they switched to a different step.
Root cause:
rabin2 -i/ imports were only documented as recommended order, not a MUST gate with Evidence contract.Changes
skills/radare2/SKILL.md: hard gate in workflow 1; recommended order + avoid list + completion checklistskills/reverse-engineering/references/re-agent-workflow.md: triage MUST include imports; block Dynamic without E-triage importsskills/ida-reverse/SKILL.md: survey step MUST write E-imports before deep diveskills/malware-analysis/SKILL.md: Phase 2 imports MUST + Evidence before Phase 3skills/llm-security/references/agent-obedience-engineering.md,RULES.md,RULES_zh.md: excuse rebuttal — redo named step X, no substituteIssue #65 problem 2 (vendor report rules) is not in this PR; waiting on vendor-style preference.
Validation (local)
skills/scripts/smoke.ps1→ ALL PASSskills/scripts/verify-routing-coherence.ps1→ ALL ROUTING COHERENCE CHECKS PASSEDMerge policy
Collaborator will merge locally after tests, then push main (per team rule).
Closes the workflow half of #65 (import-table gate). Leaves vendor-report follow-up open.