Skip to content

fix(workflow): hard-gate import table check and redo-same-step (#65) - #67

Merged
dhicoc merged 1 commit into
mainfrom
fix/issue-65-import-table-gate
Aug 11, 2026
Merged

fix(workflow): hard-gate import table check and redo-same-step (#65)#67
dhicoc merged 1 commit into
mainfrom
fix/issue-65-import-table-gate

Conversation

@dhicoc

@dhicoc dhicoc commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Summary

Addresses issue #65 (problem 1): models could skip import-table inspection, and when asked to redo that step they switched to a different step.

Root cause: rabin2 -i / imports were only documented as recommended order, not a MUST gate with Evidence contract.

Changes

  • skills/radare2/SKILL.md: hard gate in workflow 1; recommended order + avoid list + completion checklist
  • skills/reverse-engineering/references/re-agent-workflow.md: triage MUST include imports; block Dynamic without E-triage imports
  • skills/ida-reverse/SKILL.md: survey step MUST write E-imports before deep dive
  • skills/malware-analysis/SKILL.md: Phase 2 imports MUST + Evidence before Phase 3
  • skills/llm-security/references/agent-obedience-engineering.md, RULES.md, RULES_zh.md: excuse rebuttal — redo named step X, no substitute

Issue #65 problem 2 (vendor report rules) is not in this PR; waiting on vendor-style preference.

Validation (local)

  • skills/scripts/smoke.ps1ALL PASS
  • skills/scripts/verify-routing-coherence.ps1ALL ROUTING COHERENCE CHECKS PASSED

Merge policy

Collaborator will merge locally after tests, then push main (per team rule).

Closes the workflow half of #65 (import-table gate). Leaves vendor-report follow-up open.

…65)

- radare2/ida-reverse/malware-analysis: MUST record imports as Evidence before next phase
- re-agent-workflow: triage gate blocks Dynamic without imports summary
- RULES (+zh) and agent-obedience: redo named step X, no substitute
@dhicoc
dhicoc merged commit c6263c5 into main Aug 11, 2026
12 checks passed
@dhicoc

dhicoc commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator Author

本地合并流程已完成:

  1. 审查 PR 改动(7 files,导入表硬门 + 重做同一步约束)
  2. git merge --no-ff 到本地 main
  3. skills/scripts/smoke.ps1ALL PASS
  4. push main

按协作者约定:本地合并 + 测试通过后再上线。

@dhicoc
dhicoc deleted the fix/issue-65-import-table-gate branch August 11, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant