consolidate tcpclient into mssql client - #1
Open
zgoldman-r7 wants to merge 1 commit into
Open
Conversation
zgoldman-r7
pushed a commit
that referenced
this pull request
Jan 18, 2024
Quick change to add support for more sessions and to only read the fi…
zgoldman-r7
pushed a commit
that referenced
this pull request
Feb 22, 2024
Documentation: Updated instructions for setting up msfdb
zgoldman-r7
pushed a commit
that referenced
this pull request
May 28, 2024
Remove Priv Esc to add it to another module and update it to only run…
zgoldman-r7
pushed a commit
that referenced
this pull request
May 28, 2024
Added in suggestions by mcintyre
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In trying to align MSSQL client types with other client types, I'm taking this step by step, starting by getting rid of dependencies on other modules.
This is to be the first of likely 3 prs for the feature branch. Following this:
removal of
MSSQL::Baseinlib/metasploit/framework/mssql/client.rbshifting
module Clienttoclass Clientinlib/metasploit/framework/mssql/client.rbTo test, just make sure
mssql_loginmodule works as expected