Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #135.
What changed
A CLI encode now shows its progress on one line that redraws in place, like the web UI's progress bar:
EncodeJob.status()into a newEncodeProgressclass, which the web UI and the CLI both use.EncodeJobnow extends it, so the web UI code barely changed.ProgressLineclass redraws the bar from a background thread. While the encode runs, it stands in forsys.stdout, so ff4d's own prints ("Performing second pass", the retry message) start on a new line instead of running into the bar.--verboseis off. Otherwise you get ffmpeg's stats line like before.on_passis set),TwoPass.run()passes-nostatsto ffmpeg so its stats line doesn't write over the bar.--verbosestill keeps it.\r, cut to the terminal's width.Changes the web UI picks up too
Testing
uv run pytest --cov: 311 passed, 99.4% coverage.uv run ruff format . && uv run ruff check .pass.