Repository navigation
Let command-line flags override a config file, even when set to their default - #125
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #114.
A config file used to win whenever a command-line value matched argparse's built-in default, so
--config my.json -c x264 --no-approxstill encoded with x265 and kept--approxon.Now
_merge_config_args()loads the config file(s), passes their values toparser.set_defaults(), and parses the command line again. The order is command line > config file > built-in defaults, and anything you type wins.Notes:
update_args_from_config()and its== parser.get_default(k)check are removed.parse_known_args()step._search_for_default_config()doesn't change.from/tostill go through_extract_times()."config"key inside a config file is still followed. The outer file wins over the one it points to.Tests in
test_arguments.pycover-c x264,--no-approx,-s 20, and-a 64beating a config file, plus config values applying when the flag isn't passed and unrelated flags keeping their built-in defaults.