Conversation
The postinst scriptlets only ran 'systemctl enable' on fresh install, so nodes upgraded across the PR #96 [Install] target change (carbonio-appserver.target -> service-discover.target) never got the new WantedBy symlink under service-discover.target.wants/. The target then failed to pull the service at boot (CO-3797). Enable on upgrade too (yum: $1 -ge 1; apt: drop -z $2 guard) so the symlink is always reconciled against the current unit.
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage (0.00% Estimated after merge)
gjed
approved these changes
May 29, 2026
Contributor
|
🎉 This PR is included in version 0.7.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The postinst scriptlets only ran 'systemctl enable' on fresh install, so nodes upgraded across the PR #96 [Install] target change (carbonio-appserver.target -> service-discover.target) never got the new WantedBy symlink under service-discover.target.wants/. The target then failed to pull the service at boot (CO-3797).
Enable on upgrade too (yum: $1 -ge 1; apt: drop -z $2 guard) so the symlink is always reconciled against the current unit.