Skip to content

Use a normal failure instead of an assert when mailbox read fails. #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jimkeir wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use a normal failure instead of an assert when mailbox read fails. #165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/mailbox.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,10 @@ int zmq::mailbox_t::recv (command_t *cmd_, int timeout_)

// Get a command.
errno_assert (rc == 0);

// check_read says that this can fail during deallocation. So, instead of using
// the fatal zmq_assert, just return a normal failure.
bool ok = cpipe.read (cmd_);
zmq_assert (ok);
return 0;

return (ok ? 0 : -1);
}