Skip to content

Xrange to Range | Added Session and Timeout to requests | unicode was…#10

Open
shauryauppal wants to merge 1 commit into
zerodha:masterfrom
shauryauppal:master
Open

Xrange to Range | Added Session and Timeout to requests | unicode was…#10
shauryauppal wants to merge 1 commit into
zerodha:masterfrom
shauryauppal:master

Conversation

@shauryauppal

@shauryauppal shauryauppal commented Oct 3, 2020

Copy link
Copy Markdown
Contributor
  1. Xrange to Range for Python3.5+ compatible code
  2. Added Session and timeout for smooth file downloads from rbi
  3. unicode was type line was creating an issue so modified

@shauryauppal

Copy link
Copy Markdown
Contributor Author

@knadh

@knadh

knadh commented Mar 8, 2021

Copy link
Copy Markdown
Collaborator

Sorry, missed this. I vaguely remember RBI's website changing, breaking the script. Have you been using the lib? If yes, can you confirm that the lib works as is?

@shauryauppal

shauryauppal commented May 19, 2021 via email

Copy link
Copy Markdown
Contributor Author

@shauryauppal

Copy link
Copy Markdown
Contributor Author

Last, when I did the commit everything was working perfectly with the changes, don't know about the current state.

Some much-needed changes were like Xrange doesn't work anymore on Python3+ versions. So those changes to make code python3 compatible were also done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants