fix: bump @zeplin/sdk to 1.40.0 to fix get_screen crash on typeless annotations#6
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Zeplin SDK dependency to address a get_screen crash when annotations have incomplete/degenerate type data during deserialization.
Changes:
- Bump
@zeplin/sdkdependency from^1.25.0to^1.40.0.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Annotations without note type or whose note type was deleted are returned by the API with an empty
type: {}. The SDK's generated deserializer readcolor.nameunconditionally and threw "Cannot read properties of undefined (reading 'name')" inside getScreenAnnotations, failing the whole get_screen call.@zeplin/sdk@1.40.0 regenerates the note-type deserializer with guarded field access, so degenerate/partial annotation types deserialize safely.