core: Improve Serial implements#206
Open
soburi wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the Arduino Zephyr serial implementation to better align with Arduino Core semantics (buffering, Print overloads, availableForWrite(), and flush()), and adds Devicetree-driven macros to select the appropriate Serial* object for console/hardware/USB/router use cases.
Changes:
- Refactors TX/RX buffering and introduces semaphore-protected access patterns, plus UART re-init via
_reinit_if_needed(). - Updates
write()behavior to push the full payload (yielding when buffers are full), and addsavailableForWrite()/flush()/Print::writeoverload visibility. - Adds macro infrastructure to map/alias
Serialobjects based on Devicetree (console serial, hardware serial, USB CDC ACM serial, and router serial).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| cores/arduino/zephyrSerial.h | Adds new serial selection/indexing macros and updates the ZephyrSerial interface (flush(), availableForWrite(), Print::write overloads). |
| cores/arduino/zephyrSerial.cpp | Refactors IRQ handling and TX/RX operations, implements flush() and availableForWrite(), and updates serial object instantiation/event hooks. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Jul 5, 2026
- Refactored ZephyrSerial's send/receive logic and protected the RX/TX ring buffers with semaphores. - Modified `write()` to write the entire payload by calling `yield()` if the data exceeds buffer capacity. - Added support for `availableForWrite()`, `flush()`, and the `Print::write` overload to align with the Arduino Core implementation. - UART re-initialization logic move to `_reinit_if_needed()`. - Added a mechanism to shift the standard UART to `Serial1` (or higher) if `Serial` is occupied by `cdc_acm_serial` or `arduino_router_serial`. - Added macros (such as `ARDUINO_CONSOLE_SERIAL` and `ARDUINO_HARDWARE_SERIAL`) to reference `Serial` objects based on their specific use cases. Co-authored-by: Kurt Eckhardt <kurte@rockisland.com> Co-authored-by: Luca Burelli <l.burelli@arduino.cc> Co-authored-by: Martino Facchin <m.facchin@arduino.cc> Co-authored-by: Mattia Pennasilico <m.pennasilico@arduino.cc> Co-authored-by: Tamas Jozsi <tamas.jozsi@silabs.com> Co-authored-by: iabdalkader <i.abdalkader@gmail.com> Co-authored-by: kurte <kurte@rockisland.com> Co-authored-by: pennam <m.pennasilico@arduino.cc> Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
write()to write the entire payload by callingyield()if the data exceeds buffer capacity.availableForWrite(),flush(), and thePrint::writeoverload to align with the Arduino Core implementation._reinit_if_needed().Serial1(or higher) ifSerialis occupied bycdc_acm_serialorarduino_router_serial.ARDUINO_CONSOLE_SERIALandARDUINO_HARDWARE_SERIAL) to referenceSerialobjects based on their specific use cases.