Skip to content

fix: use pyodide session and min-lines/max-lines data attributes #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
squidfunk merged 1 commit into from
Jul 7, 2026
Merged

fix: use pyodide session and min-lines/max-lines data attributes #180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 7 additions & 17 deletions src/assets/javascripts/components/content/exec/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,8 @@ interface Elements {
source: string;
session: string;
install: string[];
minLines: number;
maxLines: number;
}

/* ----------------------------------------------------------------------------
Expand Down Expand Up @@ -136,20 +138,6 @@ function parsePackages(value: string | undefined): string[] {
.filter((item) => item.length > 0);
}

/**
* Extract the configured session name from the canonical scaffold
*
* @param el - Pyodide root element
*
* @returns Session name
*/
function getSessionName(el: HTMLElement): string {
const label = el.querySelector(".pyodide-editor-bar .pyodide-bar-item");
const text = label?.textContent ?? "";
const match = text.match(/session:\s*([^)]+)\)?/i);
return match?.[1]?.trim() || "default";
}

/**
* Extract the canonical scaffold elements
*
Expand All @@ -175,8 +163,10 @@ function getElements(el: HTMLElement): Elements {
run,
clear,
source: editor.textContent?.trimEnd() ?? "",
session: getSessionName(el),
session: el.dataset.session ?? "default",
install: parsePackages(el.dataset.install),
minLines: typeof el.dataset.minLines == "undefined" ? 0 : parseInt(el.dataset.minLines),
maxLines: typeof el.dataset.maxLines == "undefined" ? Infinity : parseInt(el.dataset.maxLines),
};
}

Expand Down Expand Up @@ -412,8 +402,8 @@ export function mountPyodide(el: HTMLElement): Observable<Component<Pyodide>> {
editor.setTheme("ace/theme/zensical");
editor.session.setMode("ace/mode/python");
editor.setOption("fontFamily", "var(--md-code-font)");
editor.setOption("minLines", 0);
editor.setOption("maxLines", Infinity);
editor.setOption("minLines", elements.minLines);
editor.setOption("maxLines", elements.maxLines);
editor.session.setValue(elements.source);
editor.gotoLine(1, 0, false);
editor.clearSelection();
Expand Down