Skip to content

fix: fix pyodide output escaping #179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
squidfunk merged 1 commit into from
Jul 7, 2026
Merged

fix: fix pyodide output escaping #179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 3 additions & 16 deletions src/assets/javascripts/components/content/exec/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@
* IN THE SOFTWARE.
*/

import escapeHtml from "escape-html";

import {
Observable,
catchError,
Expand Down Expand Up @@ -200,7 +198,7 @@ function getSession(name: string, pyodide: PyodideInterface): unknown {
* @param string - Output
*/
function writeOutput(element: HTMLElement, string: string): void {
element.innerHTML = escapeHtml(string);
element.textContent = string;
}

/**
Expand All @@ -209,18 +207,7 @@ function writeOutput(element: HTMLElement, string: string): void {
* @param element - Output element
*/
function clearOutput(element: HTMLElement): void {
element.innerHTML = "";
}

/**
* Escape output like the original script
*
* @param string - Raw output
*
* @returns Escaped output
*/
function escapeOutput(string: string): string {
return new Option(string).innerHTML;
element.textContent = "";
}

/**
Expand Down Expand Up @@ -264,7 +251,7 @@ async function evaluatePython(
writeOutput(output, `${lines.join("\n")}\n`);
}
} catch (error) {
lines.push(escapeOutput(String(error)));
lines.push(String(error));
writeOutput(output, `${lines.join("\n")}\n`);
}
}
Expand Down