Fix ValueError when formatVal is 0#13
Merged
Merged
Conversation
evantypanski
force-pushed
the
topic/etyp/fix-implicit-string-conversion
branch
from
October 14, 2025 12:53
d205d7c to
f4ee91d
Compare
bbannier
approved these changes
Oct 14, 2025
Using f-strings doesn't implicitly convert the val to a string, whereas before the % formatting would. Caused by linter changes 836454e.
evantypanski
force-pushed
the
topic/etyp/fix-implicit-string-conversion
branch
from
October 14, 2025 13:27
f4ee91d to
232fdaa
Compare
Member
|
Should we turn around 8.0.3 pretty quick to get this in? |
Member
Author
Probably, but not sure how often it actually happens, I'm sure it depends on the environment. Could be a real issue if it does though, if you rely on it |
Member
|
Given that we already have another driver for 8.0.3 (to get zeek-client to work out of the box again), I think we should. |
|
Let me also pitch including the ZAM use-after-free workaround! |
Member
That one is already in 😃 |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using f-strings doesn't implicitly convert the val to a string, whereas before the % formatting would. Caused by linter changes 836454e.
reported on Slack