Skip to content

Add pre-commits, add pyproject.toml#11

Merged
timwoj merged 9 commits into
masterfrom
topic/timw/pre-commit-plus-pyproject
Sep 11, 2025
Merged

Add pre-commits, add pyproject.toml#11
timwoj merged 9 commits into
masterfrom
topic/timw/pre-commit-plus-pyproject

Conversation

@timwoj

@timwoj timwoj commented Sep 10, 2025

Copy link
Copy Markdown
Member

This adds the typical set of pre-commits for Zeek Python projects and fixes all of the findings from ruff-check and ruff-format. It includes the typos pre-commit, but it didn't find anything with the bare configuration so I didn't add a typos.toml.

It also adds a pyproject.toml with the usual configuration and fleshes out the setup.py to set the version number correctly when installing via pip.

@timwoj
timwoj force-pushed the topic/timw/pre-commit-plus-pyproject branch from 0cbfa47 to 7fd17bc Compare September 10, 2025 18:54
@timwoj
timwoj requested a review from bbannier September 10, 2025 18:54
@timwoj
timwoj force-pushed the topic/timw/pre-commit-plus-pyproject branch 2 times, most recently from 361fad9 to cc05dde Compare September 10, 2025 19:23
@timwoj
timwoj removed the request for review from bbannier September 11, 2025 02:13
@timwoj

timwoj commented Sep 11, 2025

Copy link
Copy Markdown
Member Author

Putting this one on hold until I can get a new version of pysubnettree released, since I need some unreleased fixes from it for the btests to pass on Github. They work fine locally since I installed pysubnettree directly from a repo clone, but the version on pypi fails.

@bbannier

Copy link
Copy Markdown
Member

I was looking at this and about to suggest a bunch of changes, but figured just suggesting concrete code would be simpler, so I added a bunch of commits after cc05dde. Some of the patches are fixups and I added extra info to the commit message. Please feel free to pick up what you want.

@timwoj

timwoj commented Sep 11, 2025

Copy link
Copy Markdown
Member Author

I was looking at this and about to suggest a bunch of changes, but figured just suggesting concrete code would be simpler, so I added a bunch of commits after cc05dde. Some of the patches are fixups and I added extra info to the commit message. Please feel free to pick up what you want.

Those all look good. I pushed one more commit that fixes the build step. Calling the build module directly without arguments is enough to test that the packaging works.

@timwoj
timwoj requested a review from bbannier September 11, 2025 18:28
@timwoj
timwoj force-pushed the topic/timw/pre-commit-plus-pyproject branch from 6921b68 to 06f633a Compare September 11, 2025 20:08
@timwoj
timwoj merged commit ba37509 into master Sep 11, 2025
5 checks passed
@timwoj
timwoj deleted the topic/timw/pre-commit-plus-pyproject branch September 11, 2025 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants